fix: Fixes SentryScreenFrames use after being converted to Swift #5153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaybre
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 161947d+dirty | 393.26 ms | 403.00 ms | 9.74 ms |
| 818a608 | 495.84 ms | 498.08 ms | 2.25 ms |
| bc9680d | 375.15 ms | 401.12 ms | 25.97 ms |
| 276d348+dirty | 375.48 ms | 403.76 ms | 28.28 ms |
| 3099014+dirty | 439.20 ms | 468.40 ms | 29.20 ms |
| 95aaf8a | 437.89 ms | 419.45 ms | -18.44 ms |
| 6fee48d+dirty | 407.42 ms | 437.71 ms | 30.29 ms |
| ba75c7c | 367.72 ms | 369.16 ms | 1.44 ms |
| 93137d1+dirty | 400.15 ms | 424.74 ms | 24.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 161947d+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 818a608 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| bc9680d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 276d348+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| 3099014+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 95aaf8a | 17.75 MiB | 19.68 MiB | 1.93 MiB |
| 6fee48d+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| ba75c7c | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 93137d1+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2fa43d+dirty | 1216.04 ms | 1232.65 ms | 16.61 ms |
| 3bd3f0d+dirty | 1231.51 ms | 1229.10 ms | -2.41 ms |
| c4e097a+dirty | 1229.09 ms | 1242.61 ms | 13.53 ms |
| ec14be7+dirty | 1234.64 ms | 1245.54 ms | 10.90 ms |
| af9331b+dirty | 1233.61 ms | 1230.50 ms | -3.11 ms |
| 1bea095+dirty | 1234.14 ms | 1233.96 ms | -0.18 ms |
| 6a70a7e+dirty | 1225.82 ms | 1230.79 ms | 4.98 ms |
| bfe454a+dirty | 1235.33 ms | 1243.12 ms | 7.79 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| 46bd012+dirty | 1220.49 ms | 1226.89 ms | 6.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2fa43d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3bd3f0d+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| c4e097a+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| ec14be7+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| af9331b+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 1bea095+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 6a70a7e+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| bfe454a+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 46bd012+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c94a927+dirty | 411.32 ms | 443.18 ms | 31.86 ms |
| 459a438+dirty | 359.50 ms | 390.53 ms | 31.03 ms |
| 23080e5+dirty | 347.29 ms | 381.87 ms | 34.58 ms |
| 2b89ce9+dirty | 372.22 ms | 417.06 ms | 44.84 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| 0b64753+dirty | 358.55 ms | 429.16 ms | 70.61 ms |
| af9331b+dirty | 374.42 ms | 425.68 ms | 51.26 ms |
| 69602ce+dirty | 375.37 ms | 405.28 ms | 29.91 ms |
| c7f264b+dirty | 356.98 ms | 407.46 ms | 50.48 ms |
| a31630c+dirty | 359.89 ms | 416.90 ms | 57.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c94a927+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 459a438+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 23080e5+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 2b89ce9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 0b64753+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| af9331b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 69602ce+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| c7f264b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| a31630c+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2fa43d+dirty | 1224.43 ms | 1235.40 ms | 10.98 ms |
| 3bd3f0d+dirty | 1230.18 ms | 1243.41 ms | 13.22 ms |
| c4e097a+dirty | 1231.35 ms | 1246.91 ms | 15.56 ms |
| ec14be7+dirty | 1229.62 ms | 1230.53 ms | 0.91 ms |
| af9331b+dirty | 1230.08 ms | 1233.24 ms | 3.16 ms |
| 1bea095+dirty | 1218.93 ms | 1212.37 ms | -6.57 ms |
| 6a70a7e+dirty | 1231.40 ms | 1239.49 ms | 8.09 ms |
| bfe454a+dirty | 1231.82 ms | 1239.98 ms | 8.16 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| 46bd012+dirty | 1231.78 ms | 1212.30 ms | -19.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e2fa43d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3bd3f0d+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| c4e097a+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| ec14be7+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| af9331b+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 1bea095+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 6a70a7e+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| bfe454a+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 46bd012+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
|
Thank you for opening this ahead of the changes Itay. The changes LGTM. |
|
Already merged on |
|
Thank you for the heads up Itay 🙇
Noting this to merge along the next Cocoa pump 📓 |
|
@itaybre My understanding is that the changes of getsentry/sentry-cocoa#6094 were merged on main and would be released with v9. They are not part of 8.57.0. Correct? |
6 tasks
|
@itaybre FYI, I created a PR based on this one, as we also need to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
SentryScreenFramesconverted to swift in getsentry/sentry-cocoa#6094#skip-changelog